search

reagent-project / reagent-forms

Bootstrap form components for Reagent
339 stars 78 forks source link

The October's short name missing from the Datepicker's Finnish locales #145

Closed aleksiromanov closed 6 years ago

aleksiromanov commented 6 years ago

The Datapicker component uses a map of locales for several languages. Because the October's short name entry Finnish (fi-FI) locales is missing by mistake, a row is missing from the Dtapicker's months-dropdown list as well. In Finnish, the commonly used short name for October is Loka.

  1. At the moment:

$ git br -v

$ grep :months-short.Tammi.Helmi src/reagent_forms/datepicker.cljs :months-short ["Tammi" "Helmi" "Maalis" "Huhti" "Touko" "Kesä" "Heinä" "Elo" "Syys" "Marras" "Joulu"]

  1. Fix (insert missing Loka between Syys and Marras):

$ sed -i 's/"Syys" "Marras"/"Syys" "Loka" "Marras"/' src/reagent_forms/datepicker.cljs

  1. Fixed version:

$ grep :months-short.Tammi.Helmi src/reagent_forms/datepicker.cljs :months-short ["Tammi" "Helmi" "Maalis" "Huhti" "Touko" "Kesä" "Heinä" "Elo" "Syys" "Loka" "Marras" "Joulu"]

yogthos commented 6 years ago

Thanks for the heads up, any chance you could do a PR for this?

aleksiromanov commented 6 years ago

I will do this

yogthos commented 6 years ago

pushed out a new release with the fix