search

reagent-project / reagent-forms

Bootstrap form components for Reagent
339 stars 78 forks source link

:label seems to require :id in 0.2.3? #15

Closed seancorfield closed 9 years ago

seancorfield commented 9 years ago

I upgraded from 0.1.1 to 0.2.3 and got an error "Doesn't support name". I traced this down to have a :label without an :id - which used to work in 0.1.1.

I don't want the field's value to appear in the label so in 0.1.1 I used to omit :id. What's the recommended way to add a fixed text label to a field now?

yogthos commented 9 years ago

I'd just make a regular Reagent component if the label doesn't need to be data bound, e.g:

[:label "static text"]

The bind-fields function will only modify components that that have a :field attribute and leaves the rest as is. I could add the ability to omit the :id on the labels back, but is there a use case for making it a field if it's not going to be data abound?

seancorfield commented 9 years ago

I had initially tried that (on one form) and it didn't seem to work, but I think the error was coming from another form I had not updated. Once I updated all my forms to be consistent - plain labels like you suggested - it all worked. This might catch people out if they relied on the 0.1.1 behavior but it's no big deal I guess.