Allow custom names for months/day-of-week for datepicker

reagent-project / reagent-forms

Bootstrap form components for Reagent

339 stars 78 forks source link

Allow custom names for months/day-of-week for datepicker #84

Closed dmarjenburgh closed 8 years ago

dmarjenburgh commented 8 years ago

I would like to pass a custom map with month names, short-month names and day-of-week names. This way, each user can implement localised names easily.

I have a working example here. Would you be interested in supporting this behaviour? https://github.com/reagent-project/reagent-forms/compare/master...dmarjenburgh:custom-month-names

yogthos commented 8 years ago

I don't see any downsides :)

jaaqo commented 8 years ago

+1, I need to translate the names aswell.

yogthos commented 8 years ago

@dmarjenburgh any chance you'd be interested in doing a pr for this?

jaaqo commented 8 years ago

@yogthos would you be interested in something like this? 7735d021f857afe73ad4c0e864916c91637d1f10

Basically same as dmarjenburghs but with some built in translations for ease of use

yogthos commented 8 years ago

@jaaqo yeah that looks good to me

dmarjenburgh commented 8 years ago

:+1

yogthos commented 8 years ago

this pr should do it https://github.com/reagent-project/reagent-forms/pull/91 and I've pushed the latest to Clojars