search

reagent-project / reagent-template

A Leiningen template for projects using Reagent.
MIT License
394 stars 55 forks source link

Duplicate initialization call? #135

Closed hrehfeld closed 7 years ago

hrehfeld commented 7 years ago

I'm trying the template, but I need to configure figwheel with a different :websocket-host:

  {:builds {:dev
        {:source-paths ["src/cljs" "src/cljc" "env/dev/cljs"]
         :figwheel {
                    :websocket-host "192.168.1.101"}
 ....

This is NOT working in this template, but works in the getting started example.

The problem seems to be that two init calls are generated. The first one has hardcoded websocket params:

(figwheel/watch-and-reload
  :websocket-url "ws://localhost:3449/figwheel-ws"
  :jsload-callback core/mount-root)

I can just comment out these lines, and everything works fine. I think this is a bug, and the call should be removed. The figwheel function even says: "legacy interface"

yogthos commented 7 years ago

I think you're right, the legacy code never got removed from the tempalte.

yogthos commented 7 years ago

fixed by https://github.com/reagent-project/reagent-template/commit/7820f4afb490132694eeed472eba5630c0ddc17c

hrehfeld commented 7 years ago

Thanks!