search

reagent-project / reagent-template

A Leiningen template for projects using Reagent.
MIT License
394 stars 55 forks source link

What's the point of having a :production profile? #16

Closed devth closed 9 years ago

devth commented 9 years ago

https://github.com/reagent-project/reagent-template/blob/master/src/leiningen/new/reagent/project.clj#L76-78

This was misleading to me: I assumed when I compiled my app for production using lein ring uberjar the production profile would be active, but it's not. Is there another purpose? Otherwise, these ring settings should just be moved into the uberjar profile.

yogthos commented 9 years ago

This allows lein-ring to set the Ring settings for both uberjar and uberwar profiles if I recall correctly.

devth commented 9 years ago

Ah, that makes sense. I thought it wasn't being picked up because I tried putting :port 8080 in :production {:ring ..} but ring still used port 3000. I also tried putting the :port setting in the :uberjar profile with no luck, so must be another problem.