search

reagent-project / reagent-template

A Leiningen template for projects using Reagent.
MIT License
394 stars 55 forks source link

Add testing infrastructure to the generated project #27

Closed ducky427 closed 9 years ago

ducky427 commented 9 years ago

I think that the generated project.clj should have the testing infrastructure present in it.

yogthos commented 9 years ago

would you be up for adding that?

ducky427 commented 9 years ago

I'll give it a shot. I am planning to use clojurescript.test framework as cljs.test is still too new and doesn't have the supporting tools yet.

On 16 Jan 2015, at 13:37, Dmitri Sotnikov notifications@github.com wrote:

would you be up for adding that?

— Reply to this email directly or view it on GitHub.

yogthos commented 9 years ago

That sounds reasonable, I think something that has better tooling would definitely be a good way to go. It might make sense to make this an optional flag though as it relies on having phantom.js installed as I recall?

ducky427 commented 9 years ago

That's correct. You would need phantomjs installed. So an optional flag makes sense.

On 16 Jan 2015, at 15:02, Dmitri Sotnikov notifications@github.com wrote:

That sounds reasonable, I think something that has better tooling would definitely be a good way to go. It might make sense to make this an optional flag though as it relies on having phantom.js installed as I recall?

— Reply to this email directly or view it on GitHub.

ducky427 commented 9 years ago

I've added a test to a sample repo ducky427/reagtest@73ef6ba2da1c48f3c65e82e5f6a99495c6393265

Notes:

Once we are ok with this end result, I can add the changes to the template.

yogthos commented 9 years ago

That seems reasonable to me, @holmsand, @seancorfield, @Frozenlock, @gadfly361 any comments suggestions before we merge this in? :)

Frozenlock commented 9 years ago

All I can say is that it's more than time that I start testing they UI side of my reagent apps. Having it baked in the template would be very nice. :+1:

gadfly361 commented 9 years ago

Whenever I want to test things, I have been using Chestnut because it includes speclj. So I am excited to see a testing addition to reagent-template! :+1:

seancorfield commented 9 years ago

Big :+1: from me for building testing into the template!

ducky427 commented 9 years ago

Great. I've just sent a P-R for this. Please have a look and let me know what I have done is appropriate.

cheers!

yogthos commented 9 years ago

everything looks good to me, I pushed the latest on Clojars

ducky427 commented 9 years ago

cheers!