reagent-project / reagent-template

A Leiningen template for projects using Reagent.
MIT License
394 stars 55 forks source link

add http-kit profile #46

Open yogthos opened 9 years ago

piecyk commented 9 years ago

:+1:

mccraigmccraig commented 9 years ago

i took a basic reagent-template app and modified it to work with aleph/manifold... which probably satisfies the same itch you are looking for http-kit to scratch (async, websockets) ?

https://github.com/mccraigmccraig/sparky-elephants

the aleph server doesn't support the :auto-reload? option so i added a ring handler based auto-reload solution :

https://github.com/mccraigmccraig/sparky-elephants/blob/master/env/dev/clj/sparky_elephants/repl.clj

i could port the changes back to an aleph profile in the reagent-template project if you are interested ?

yogthos commented 9 years ago

there's actually an easier way, you can use ring.middleware.reload as I'm doing in Luminus here.

mccraigmccraig commented 9 years ago

hmm, iirc i had problems with ring.middleware.reload not re-creating the handler chain, so i modified ring.middleware.reload ( https://github.com/mccraigmccraig/sparky-elephants/blob/master/env/dev/clj/sparky_elephants/wrap_reload.clj ) and then recreate the handler chain on each request

mccraigmccraig commented 9 years ago

anyway, sounds like you don't need any help with aleph ;)

yogthos commented 9 years ago

Ah yes I've noticed that as well, route modifications don't get reflected either. I wouldn't mind adding aleph profile as well, just need time. :)

mccraigmccraig commented 9 years ago

if you would take a PR, i could do an aleph profile in the next few weeks ?

yogthos commented 9 years ago

that would be fantastic :+1:

mccraigmccraig commented 9 years ago

cool, i'll get on it when i have a moment :)

alehatsman commented 7 years ago

@mccraigmccraig so have you had a moment since 2015 ?) Does somebody actually interested in this staff ?

mccraigmccraig commented 7 years ago

@Atsman i haven't! i only went and started a new company 😬