search

reagent-project / reagent-template

A Leiningen template for projects using Reagent.
MIT License
394 stars 55 forks source link

core.cljs is overwritten by core.cljx #5

Closed Frozenlock closed 9 years ago

Frozenlock commented 9 years ago

I scratched my head for quite a while trying to understand why the compiled js wasn't the one in core.clj. Turns out there's a default core.cljx that's overwriting the file when generating the cljs version.

yogthos commented 9 years ago

Sounds like the core.cljx could probably be removed entirely since it doesn't do anything useful.

Frozenlock commented 9 years ago

Or perhaps just name it core2.cljx or something?

It's nice to have the .cljx file, because you immediately know where it's supposed to be without looking at your project.clj.

yogthos commented 9 years ago

That's a good point, so possibly util.cljx or something then. :)

yogthos commented 9 years ago

Ok renamed and pushed out a new template to clojars, I notice that I have to also run lein cljx explicitly I haven't looked hard to see if there's a way around that though.

On an unrelated note, are you still up for adding historian to the org? :)

Frozenlock commented 9 years ago

Great, I'll close this issue then.

For Historian: Am I, but I haven't received many criticisms (good or bad) on the issue.

yogthos commented 9 years ago

ah I didn't notice the issue, I see Sean commented already :)