search

reagent-project / reagent-template

A Leiningen template for projects using Reagent.
MIT License
394 stars 55 forks source link

app-state & page to render function and Multi-methods #7

Closed ducky427 closed 9 years ago

ducky427 commented 9 years ago

In {{project-ns}}.core, instead of storing the function to render itself like page1, page2 in app-state, wouldn't it be better to just store the identifier in app-state, like :page1, :page2 and then we can convert page1 and page2 to multimethods.

I just felt its more transparent on what is happening.

My two cents.

cheers

yogthos commented 9 years ago

That sounds reasonable to me, it's not a big change conceptually but might make the intent more clear.

ducky427 commented 9 years ago

I can work up a P-R based on this.

cheers!

yogthos commented 9 years ago

that would be fantastic :+1:

Frozenlock commented 9 years ago

Can this be closed?