search

reagent-project / reagent-template

A Leiningen template for projects using Reagent.
MIT License
394 stars 55 forks source link

Run tests with something other than phantom (slimerjs) #72

Closed JarrodCTaylor closed 9 years ago

JarrodCTaylor commented 9 years ago

I am building a project and utilizing storage-arom to interface with the browsers localStorage. This works as expected in the app. However, running tests with Phantom is not playing nice issue #10. Looking over the readme for clojurescript.test they recommend using slimjerjs. According an issue in the clojurescript.test repo slimerjs is a drop in replacement for phantomjs, but I seem to be missing something with the reagent-template. When I sub in slimerjs I only get the following outout when trying to run tests.

Compiling ClojureScript.
Running ClojureScript test: unit
Subprocess failed
JarrodCTaylor commented 9 years ago

I still haven't had any luck being able to run tests in an app that accesses localStorage. I am not committed to slimerjs being the solution if something else can accomplish the goal.

I would be willing to help work on a solution if there is a preferred path and if I had an idea of how to start.

yogthos commented 9 years ago

It might be worth asking a question on the ClojureScript google groups or Slack to see if anybody had success with this. If you can get it working I can definitely help with finishing up the pr and pushing this out in the new template.

JarrodCTaylor commented 9 years ago

Will do. I will let you know if I get anything worked out.

JarrodCTaylor commented 9 years ago

After poking around I came across this issue turns out the inability to access localStorage was a known issue inside the clojurescript.test project and was fixed in version 0.3.3. I have confirmed that the tests will run as expected when using version 0.3.3 and open PR #75 to update the version in the template.

yogthos commented 9 years ago

fantastic!