search

reagent-project / reagent-template

A Leiningen template for projects using Reagent.
MIT License
394 stars 55 forks source link

Update to latest Figwheel and other dependencies. Make new projects pass lein check. #93

Closed kenrestivo closed 8 years ago

kenrestivo commented 8 years ago

Makes new projects pass "lein check" and "lein ancient" without errors.

yogthos commented 8 years ago

Are all the exclusions there just for lein check, I don't think it makes much difference in term of working with the project, but makes the project definition a bit noisier. Is there a specific benefit for doing that?

kenrestivo commented 8 years ago

The reason is to make lein check less noisy :) It's very noisy without them, And also to make the dependencies explicit and precise and predictable instead of the result of random interactions. It also provides the most recent version of some of the dependencies. Without these, in many cases an older version of some library overrides a newer version.

The least noisy fix for everyone might be for some projects like figwheel that have old dependencies to update their dependencies. I might submit an issue for them as well.

yogthos commented 8 years ago

Sounds good, if the upstream projects update then it would be nice to prune this at some point.

yogthos commented 8 years ago

Hmm the update seems to generate a broken project.clj file, could you fix that up.

kenrestivo commented 8 years ago

Ack, fixing now. Will push in a few. Thanks!

kenrestivo commented 8 years ago

OK I updated them. I'll make a pull request for figwheel to update their dependencies as well.

yogthos commented 8 years ago

ok great, and I think you'll have to do a new pr since this one's already merged in