reagent-project / reagent

A minimalistic ClojureScript interface to React.js
http://reagent-project.github.io/
MIT License
4.76k stars 414 forks source link

Bad react key warning when using false as key #569

Closed Deraen closed 2 years ago

Deraen commented 2 years ago

At least in some cases (maybe :> etc.) adding React key to item in a seq with metadata will trigger warning about missing key, if the key is false.

False should be considered valid key. expand-seq-dev already checks for nil? but problem is probably in react-key-from-vec which looks key using or so it will ignore false value.