search

reagentoo / gentoo-overlay

This repository has been moved to https://gitlab.com/reagentoo/gentoo-overlay
9 stars 3 forks source link

sci-electronics/eagle: eutils #11

Open jonasstein opened 6 years ago

jonasstein commented 6 years ago

Hi, do you really need eutils here? https://github.com/reagentoo/gentoo-overlay/blob/master/sci-electronics/eagle/eagle-8.3.1.ebuild#L6

https://github.com/reagentoo/gentoo-overlay/blob/master/sci-electronics/eagle/eagle-8.3.1.ebuild#L51 needs local f

after installing icons you need to update see: https://wiki.gentoo.org/wiki/Notes_on_ebuilds_with_GUI

have a look at the rm lines. Do you really need them? ln and rm would also need die here

reagentoo commented 6 years ago

Should I partially delete binary libs or keep them all? Please check new ebuild: https://github.com/reagentoo/gentoo-overlay/commit/9259810e79adbba7ad6e600277f29824d9205b61

jonasstein commented 6 years ago

well done. This is much better. You can discuss your ebuild on IRC #gentoo-dev-help for more improvements. idl0r is working on eagle too, I pinged him yesterday because of the forgotten bump request ticket. You find him on IRC too and discuss the binary libs with him.