search

reagro / carob

Aggregating agronomic data
GNU General Public License v3.0
19 stars 28 forks source link

Updated Script in Pending moved back to scripts/conservation_agriculture #431

Closed smkuhlani closed 2 months ago

smkuhlani commented 2 months ago

Revisions made: doi_10.18167_DVN1_2EHEQT.R 1-Added fertilizer ammounts, which were missing. 2-Manually added the RIS file, since the journal could not provide a download option. 3-Please note, for some reason, 'treatment_vars', was not able to accept the proper terms 'land_prep_method;;crop_rotation', but i used 'yield'.

rhijmans commented 2 months ago

Thank you. I put it back in pending because the "treatment_vars" (according to you they are "land_prep_method;crop_rotation") must exist as variables in the data. They do not exist as variable, and they should be added if these are indeed the treatments. yield can never be a treatment variable. I also have some doubt about the P and K amounts. It would be good to add a comment to explain the computation of these amounts (why they are computed that way). I updated some other parts of the script to comply with the current style. I also fixed the value of trial_id.