reagro / carob

Aggregating agronomic data
GNU General Public License v3.0
20 stars 29 forks source link

Revised a data set in the pending folder. #456

Closed smkuhlani closed 3 months ago

smkuhlani commented 3 months ago

Consider this data set in pending/conservation_agriculture, for transfer to the scripts/agronomy.

FYA: 1-Added 2 additional data sheets which were not initially processed. 2-As a result, almost everything has been changed from the initially submitted data set. 3-The 3rd data sheet (HRS sunn hemp yield), does not have grain yield, but only biomass. It is therefore not clear whether we should have it or not. As of now i have removed those rows with no yield. May you please advise.

rhijmans commented 3 months ago

Thanks that is indeed a completely different script. It is almost there I think.

From the experiment description I see that land preparation and residue management are the main treatments, so I changed "treatment_vars" to

treatment_vars = "land_prep_method;residue_prevcrop;intercrops;crop_rotation" perhaps it should also include "planting_method"

But some of these variables are currently not created, so they need to be added.

Also: how do you know that residue/biomass yield is expressed as dry matter (whereas grain yield is expressed as fresh weight?)

sunn hemp does have yield (but the yield_part is not grain).

please do not remove records to avoid a warning (the low yield warning for sunn hemp was a false positive).