search

reagro / carob

Aggregating agronomic data
GNU General Public License v3.0
18 stars 28 forks source link

Revised script in pending #462

Closed smkuhlani closed 1 month ago

smkuhlani commented 1 month ago

Revised script in pending, for consideration to transfer to scripts/a…

1- Residue_prevcrop, is challenging because there is no explicit mention of how much residues were carried over. You only assume based on the previous biomass. According to literature they evenly spread the residues in the plot https://acsess.onlinelibrary.wiley.com/doi/abs/10.2135/cropsci2014.11.0796 In some cases the number of plots change from 20 to 25, in the next year. It therefore becomes unclear, what residues was applied and where they came from. Maybe they get them from outside the field.

2-It is not clear, if ether grain or biomass are expressed in fresh weight or dry weight. Based on the paper above they dry them and then reweighed. So i assumed its dry weight.

rhijmans commented 1 month ago

Thank you very much. Please avoid PRs with more than one file, because then we do not easily know what file your or my comments refer to.

rhijmans commented 1 month ago

I used a logical variable residue_prevcrop_used instead of residue_prevcrop. I would prefer the latter, but the script would need match the plots. You assumed that they were always in the same order, but I am not sure if that is correct. The raw data have "Plot no" but each plot occurs many times. So it might depend on plot/treatment/rep.