reagro / carob

Aggregating agronomic data
GNU General Public License v3.0
18 stars 28 forks source link

fix doi_10.25502_ec86-2t29.R #489

Closed egbendito closed 3 weeks ago

egbendito commented 3 weeks ago

Banana intercrop is still missing...

rhijmans commented 3 weeks ago

Thanks for picking this one up. The yields seem unrealistically high for bean. I have agreed with JvH to sit down and go over the N2A data, so for now I guess it is what it is, but I would not mind leaving N2A in pending.

Also, I cannot see the changes you made. I do not know what you did exactly, but I would suggest editing in _pending and commit the changes. Then, when you are done editing and if you are confident that the script should move out of _pending, use git mv (maybe only on linux?) or cut and paste and use git add and git commit (git understands it is a move if it is the same file in a different location).

egbendito commented 3 weeks ago

Also, I cannot see the changes you made. I do not know what you did exactly, but I would suggest editing in _pending and commit the changes. Then, when you are done editing and if you are confident that the script should move out of _pending, use git mv (maybe only on linux?) or cut and paste and use git add and git commit (git understands it is a move if it is the same file in a different location).

Sorry for the confussion.

I just learnt that git cannot keep track of the changes and the renaming all at once... I didn't know it was 3 steps:

  1. git commit
  2. git mv
  3. git commit (the renaming)