search

reagro / carob

Aggregating agronomic data
GNU General Public License v3.0
18 stars 28 forks source link

Adding a dataset doi_10.21223_P3_NQBNWX #490

Closed henryjuarez closed 3 weeks ago

henryjuarez commented 3 weeks ago

This is a clean one.

rhijmans commented 3 weeks ago

Hi Henry, I have moved these to the _pending folder because the coding style is not compliant with the current conventions..

Can you please fix these by following _template.R and the examples of some recent files in the varieties folder? And then make a new PR?

Also: you have this 

  "Description:
    [copy the abstract from the repo]
  "

I hoped it would be obvious that you would copy the abstract from the repo?

Please do not include anything like this that is not related to processing the data:

metadata_requirements <- read.csv("https://raw.githubusercontent.com/reagro/terminag/main/variables/variables_metadata.csv", sep = ",")
  metadata_requirements <- metadata_requirements[which(metadata_requirements$required=="yes"),]

(and, by the way, the above could be done with:

x <- carobiner::accepted_variables("metadata")

)