search

reagro / carob

Aggregating agronomic data
GNU General Public License v3.0
18 stars 28 forks source link

review of doi_10.5061_dryad.3692hh9.R #493

Closed egbendito closed 3 weeks ago

egbendito commented 3 weeks ago

adding reference for publication

rhijmans commented 3 weeks ago

Thanks for looking these things up. I have simplified things a bit, based on what I saw from you is that the "diagnostic" is the same everywhere. Is that correct?

rhijmans commented 3 weeks ago

This is my commit 8bd6dc961bc0eda674513e100fe3027c33272110

egbendito commented 3 weeks ago

the "diagnostic" is the same everywhere. Is that correct?

Yes, according to the publication, they seem to be consistent, except for some seasons in Rwanda that they have 50% and 150% extra micronutrients. And Kenya, where apparently "diagnostic" wasn't a treatment.

rhijmans commented 3 weeks ago

some seasons in Rwanda that they have 50% and 150%

That was not captured in your code, I think? (and is not captured now)

egbendito commented 3 weeks ago

I checked the values of the dataset and looks like the source data for Rwanda (2015B) includes 2 additional treatments with 50% lower and 150% higher micronutrients. I think that's what the paper refert to?