reagro / carob

Aggregating agronomic data
GNU General Public License v3.0
18 stars 28 forks source link

commit of agronomy script hdl:11529/10548651 #495

Closed Cliffoe08 closed 3 weeks ago

Cliffoe08 commented 3 weeks ago

kindly review script

rhijmans commented 3 weeks ago

Thank you.

Moved to _pending because the script (correctly, I think) has treatment_vars = "herbicide_product", but there is no variable herbicide_product. Can you please fix it there and make a new PR?

You did not include the dataset description text from the website

Also, and I have said this before, please carefully look at my edits and please do the same in the future.

You had

d$trial_id <- 1
d$trial_id <- as,character(d$trial_id)

Where you can do

d$trial_id <- "1"
Cliffoe08 commented 3 weeks ago

Made all the necessary adjustments. On the herbicide and treatment, i have contacted the owner and will make a new PR with more dataset info