reagro / carob

Aggregating agronomic data
GNU General Public License v3.0
20 stars 29 forks source link

commit of agronomy script hdl:11529/10548518 #524

Closed Cliffoe08 closed 2 months ago

Cliffoe08 commented 2 months ago

kindly review script

rhijmans commented 2 months ago

I see several treatments (weeding, line sowing; variety) that should be included as "treatment_vars".

unique(d$treatment)
# [1] "Farmers' practice (80:40:40)"                       "Line sowing + FP (80:40:40)"                       
# [3] "Nutrient management (140 :51 :76) + FP "            "Weed control + FP (80:40:40)"                      
# [5] "Conventional best bet (140 :51 :76)"                "CA based best bet- Strip tillage (140 :51 :76)"    
# [7] "DKC 7074"                                           "DKC 9133"                                          
# [9] "DKC 1926"                                           "Pioneer P 3501"                                    
#[11] "OPV-Navjot"                                         "Pioneer P 3441"                                    
#[13] "Syngenta NMH 713"                                   "Syngenta NK 6240"                                  
#[15] "N Omission +( Micro-nutrient +S) +lime (0:70:120)"  "P Omission +( Micro-nutrient +S) +lime (150:0:120)"
#[17] "K Omission +( Micro-nutrient +S) +lime (150:70:0)"  "NPK +( Micro-nutrient +S) +Lime (150:70:120)"      
#[19] "NPK +( Micro-nutrient +S) -Lime (150:70:120)"       "NPK -( Micro-nutrient +S) +Lime (150:70:120)"      
#[21] "Nutrient Expert Rec. for maize (140:51:76)"         "State recommendation (120:60:60)"                  
#[23] "Maize Crop Manager recommendation (160:100:80)"    

Also:

I have move the script to "_pending/agronomy". Can you please fix it and make a new PR?