search

reaktivity / k3po-nukleus-ext.java

K3PO Nukleus Extension
Apache License 2.0
0 stars 9 forks source link

nukleus:update option set to none fails #22

Closed NicoletaOita closed 5 years ago

NicoletaOita commented 7 years ago

Steps to reproduce: Unignore and run the test SimplexIT.shouldThrottleInitialOnlyClientSentDataUpdateNone added in this PR.

NicoletaOita commented 7 years ago

I've created a PR for this issue, but I've noticed that the k3po-nukleus-extension repo was extensively changed since I've started to work on it. After merging the latest sources, the test failed, so I'll have to investigate more to see why this is happening now with the new updates.

NicoletaOita commented 7 years ago

I've updated the PR, it seems the test failed because of the way I solved the conflicts when merging. @dpwspoon Please review. The fix is to send reset when the "update" option is set to none and the size of the window is smaller than the bytes that could be read. I'm not sure at this part how to calculate the bytes that are at some point using the window (readableBytes is always 1).

jfallows commented 5 years ago

Determined that we do not need to resolve this.