Open dpwspoon opened 7 years ago
The BEGIN
extension presented by the tcp
nukleus has structure TcpBeginEx
from tcp.idl
, however the ws
nukleus just tries to interpret the bytes as a WsBeginEx
, as it would for ws
echo scenario.
We need a way to either indicate the type of the BEGIN
extension, or add the capability to omit the BEGIN
extension, perhaps when configuring the ROUTE
.
It may be desirable (and more efficient) to opt-in to the BEGIN
extension and omit by default, however that would also impact logging.
We now have typeId
on core::stream::Extension
which can be used to identify the owner nukleus.
However, this can still be an issue for back to back proxying, such as tcp
to tls
proxy.
When running a WS to TCP proxy I had the following config (note: this is js code not checked in currently)
The "empty" extension from the tcpOutput is presented to the WebSocket. The WebSocket doesn't know what to do with that extension, as it as already negotiated echo