search

realFlowControl / 1brc

MIT License
30 stars 13 forks source link

Multi threaded version gives the wrong maximum values! #5

Closed tssajo closed 1 week ago

tssajo commented 2 weeks ago

I believe line 120 should be:

} elseif ($measurement[1] > $result[1]) {

instead of

} elseif ($measurement[1] < $result[1]) {

because you are looking for the maximum value there, not the minimum!

realFlowControl commented 1 week ago

You are right, thanks 🙇