realJoshByrnes / IRC2017

Public bug tracker for IRC2017 (irc.irc7.com)
0 stars 0 forks source link

To ensure channel/user modes are correctly enforced #21

Open jyonxo opened 7 years ago

jyonxo commented 6 years ago

All channel modes should be implemented apart from OnStage (+g) and profanity filter (+f) All user modes should be implemented

jyonxo commented 6 years ago

After speaking with John, OnStage and Profanity functionality is deferred until another time.

Besides the above someone needs to test all modes

realJoshByrnes commented 6 years ago

There's no reason to defer these, as they are two of the easiest modes to implement (particularly F).

Create a badwords.txt file and check if it's listed.

As for the event channel mode, it requires two additional PRIVMSG like commands. The rest is done by the client

jyonxo commented 6 years ago

Alright then you do it :P

jyonxo commented 6 years ago

So +g is already in as a mode, and for +f I will make a json file that we can maintain, badwords.json or something as you said. I will then load that in memory and run them by the filter.

realJoshByrnes commented 6 years ago

Suggestion for badwords format

? Matches any character * Matches any amount of characters

Alternatively, it may be useful to match with regex, but that could lead to some issues. Thoughts?

jyonxo commented 6 years ago

as far as I remember MSN held a list of words and that was it...

On Wed, May 23, 2018, 01:21 Joshua Davison notifications@github.com wrote:

Suggestion for badwords format

? Matches any character

  • Matches any amount of letters

Alternatively, it may be useful to match with regard. Thoughts?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ozjd/IRC2017/issues/21#issuecomment-391233542, or mute the thread https://github.com/notifications/unsubscribe-auth/ATzlQ-qSaNxEYGgiNlInjMVFN1RNgE-Kks5t1P_pgaJpZM4OvKQr .