realJoshByrnes / IRC2017

Public bug tracker for IRC2017 (irc.irc7.com)
0 stars 0 forks source link

Update Kill to support OID/Nickname/Channel #40

Open jyonxo opened 6 years ago

jyonxo commented 6 years ago

KILL Nickname - Should kill every instance of that nickname on the server KILL OID - Should determine whether user/channel and kill appropriately KILL Channel - Should kill Channel KILL Channel Nickname - Should only kill user on that channel connection

realJoshByrnes commented 6 years ago

While I agree we should be able to close channels easily, I don't think KILL is the correct way to do so. An alternate command should be considered, or (perhaps) it should be done by a bot - as per almost every other IRCd.

jyonxo commented 6 years ago

This got implemented with the following supported parameters:

Supports KILL OID1,OID2,OID3 Reason Can mix user / chan OID

Supports KILL %#Channel Supports KILL Name (Will only kill the first occurrence of that nickname)

Killing a channel will behave as follows: 1) If any users of equivalent level (including yourself) are in the channel, the channel will not close 2) All users with a level less than you will get killed from the channel and any other channels they are members of 3) If the channel is registered it will not be closed 4) If you are not inside the channel and everyone was killed successfully the channel will close

For killing a user it is as follows: If user level is less or same as you (including yourself) they (or you) will be killed from all channels they are on

jyonxo commented 6 years ago

Does not support: KILL %#Channel Nick

at the moment

realJoshByrnes commented 6 years ago

At present, KILL should be removed as it may/will kill unintended connections. I would suggest it kill nicknames in common channels as the operator. This is also how MSN worked, but obviously only one channel was allowed.

jyonxo commented 6 years ago

What if we only support OID on KILL. Then we have something else to identify peoples OID on the network. I want the ability to KILL channels. I also dont want to be in a channel necessarily when I KILL, and also I want to be able to KILL a bunch of stuff at the same time.

I dont mind limiting it to OID if that helps, then we could have a way to identify users by their OID to be sure we know who the right one is before killing.

realJoshByrnes commented 6 years ago

Kill %#chan :reason Kill nick :reason (comchan)

Future: Kill %#chan nick :reason

Nick and Chan should be interchangeable with an OID either way. It would be advantageous to have it check OID in the find nickname/channel routines.

jyonxo commented 6 years ago

Resolved by RE command for admins