realJoshByrnes / IRC2017

Public bug tracker for IRC2017 (irc.irc7.com)
0 stars 0 forks source link

ERRORNEOUS nickname not shown #7

Open realJoshByrnes opened 7 years ago

realJoshByrnes commented 7 years ago

When first connecting, typing NICK will allow ANY nickname. (without showing an error message)

If first char of nickname is not '>', it should prepend '>' Then usual error checking of nickname (for guest) should commence.

If that nickname fails, the error should indicate the ORIGINAL nickname that was specified (param 0)

eg.

-> NICK JD (server verifies if '>JD' is a valid nickname) - If not: <- :TK2CHATCHATA01 432 * JD :Erroneous nickname

jyonxo commented 7 years ago

We need a discussion over this as this is how MSN used to work from what I recall. The nickname checks depend on whether someone is GateKeeper (>) or GateKeeperPassport (without >). I would have to otherwise have a third profile which is ok with either first.

I am not happy with the idea of having to change all nicks to > first and then revert after, its not a good solution. I am open to suggestions but it might be quite a bit of effort to re-write this.

realJoshByrnes commented 7 years ago

MSN wouldn't consider the NICK until after the AUTH from memory. We have to assume the default NICK command refers to an ANON user unless it has authenticated.

Passport User AUTH MSNREGCOOKIE

or

AUTH USER+NICK combo

Guest user: AUTH NICK >*

ANON user: USER+NICK combo

Conclusion: Pre-AUTH, We have to consider any NICK command to be ANON

jyonxo commented 7 years ago

That wont work, I used to NICK >guest all the time before authenticating without an error.

Actually I dont remember MSN checking the nickname before auth I dont remember getting Erroneous nickname before auth either. The way it works at the moment is it will take any nickname and after auth during registration it will call Erroneous Nickname.

realJoshByrnes commented 7 years ago

Unless you use an invalid nickname, and are left there with 0 errors, and what appears to be a connection issue. That doesn't happen on any network I've ever seen, except IRC7.

jyonxo commented 7 years ago

MSN Chat

jyonxo commented 6 years ago

As far as I am aware the nick/user combo pre-post auth seems to be OK now. Someone needs to test this.