search

realTobby / ImageScraper

Dumps all images from a WebSite.
GNU General Public License v3.0
8 stars 2 forks source link

Multiple Websites throw scriptErrors #21

Closed realTobby closed 5 years ago

realTobby commented 6 years ago

These websites are still getting dumped, but they throw script errors and if you rush trough them by hitting "yes" about the question if you want to proceed running the script its all good. But the process is a bit annoying.

dabutvin commented 6 years ago

do you have an example to test with?

I'm prettry sure we just have to set this to true https://msdn.microsoft.com/en-us/library/system.windows.forms.webbrowser.scripterrorssuppressed%28v=vs.110%29.aspx?f=255&MSPPError=-2147217396

realTobby commented 6 years ago

Hey, i tested it with this website: https://www.pokewiki.de/Pok%C3%A9mon-Liste maybe you have the same outcome.

realTobby commented 6 years ago

Okay I implemented it, maybe its in the wrong place tho, but it works. Please look over it and tell me if it okay there. (https://github.com/xSillusx/ImageScraper/commit/05f8b52d5fad0badc33c11fd294db2852da12cf5)

bx-r0 commented 6 years ago

Any more problems with this, did the line below solved the issue? https://github.com/xSillusx/ImageScraper/blob/7e061e5aaf2da714ffa421ae963828fe80997798/ImageScraper/Form1.cs#L40

realTobby commented 6 years ago

Yes, there are no scripterrors showing to the user anymore

realTobby commented 5 years ago

Refactoring process, Issue is obsolete now