realTobby / ImageScraper

Dumps all images from a WebSite.

GNU General Public License v3.0

8 stars 2 forks source link

Seperate the dumping process into another thread #4

Closed realTobby closed 6 years ago

realTobby commented 6 years ago

When doing that, it would be possible to stop the dumping at some point if the dump is taking too long for you

realTobby commented 6 years ago

it currently blocks the UI Thread, so no scrolling in log, or previewing

AidanFray commented 6 years ago

I'm keen to take this one, I'll jump on it today if no one else is working on it?

realTobby commented 6 years ago

Yea that would be great. Iam currently doing comments and trying to merge all the stuff that is contibuted. I think Iam close to finishing the merging. I will commit in maybe an hour again all the changes. Then we should all be on the same page again ^^

realTobby commented 6 years ago

solved with https://github.com/xSillusx/ImageScraper/pull/24

AidanFray commented 6 years ago

26 Seemed to have removed part of the threading, the program seems to not be threaded anymore?