search

realXtend / tundra

realXtend Tundra SDK, a 3D virtual world application platform.
www.realxtend.org
Apache License 2.0
84 stars 70 forks source link

Replaced u8 connectionID with a VLE8/16/32 ID. #562

Closed cvetan5 closed 11 years ago

cvetan5 commented 11 years ago

See issue #471

jonnenauha commented 11 years ago

@juj I think if this potentially breaks wire protocol we should try to merge this before 2.4 release? Would be a perfect time to break it with a "major" version change.

juj commented 11 years ago

Yes, this definitely breaks compatibility both ways.

Stinkfist0 commented 11 years ago

Mixing of u32 and unsigned int can (should) be removed after this commit is in https://github.com/LudoCraft/Tundra/commit/d1e56c694ee17f39cf35085116a4c164e6ce8b36

jonnenauha commented 11 years ago

So as it breaks compatibility should we still push for this to be merged on the big new version change of 2.3 -> 2.4? I don't like the idea that 2.4.0.1 or something similar breaks protocol :-1: Even if this means the release is delayed for a couple of days. Do you see anything wrong with the code right off the bat? Of course this needs lots of testing. We will do our share once this is in tundra2.

jonnenauha commented 11 years ago

Was just told by @juj that this is in the 2.4 RC1 so seems we are all good.