search

realXtend / tundra

realXtend Tundra SDK, a 3D virtual world application platform.
www.realxtend.org
Apache License 2.0
84 stars 70 forks source link

Visual Studio 2010 support #612

Closed Stinkfist0 closed 11 years ago

Stinkfist0 commented 11 years ago

-Re: #597 -Tested on 32-bit Windows 7 and 64-bit Windows Vista with VS2010 Express with SP1 -NOTE: the script tries to fetch Qt from a broken URL and this is not fixed on purpose as it's already fixed in the mainline https://github.com/realXtend/naali/blob/tundra2/tools/windows-build-deps.cmd#L166 -Bullet build improved by using CMake and by omitting the unnecessary samples and demos from the build

Known issues: -Speex is skipped for now, the solution and project files need hacking in order to make it build with VS2010 -Even though Celt seems to build fine, MumblePlugin fails to link to it -VLC's VS2008-built binaries are not compatible with VS2010 binaries, so VLC is skipped in the process

jonnenauha commented 11 years ago

Seems like a stand up job. I like how you split the "bootstrap" files separately for VC9/10 and kept the build script handle all kinds of configs in the same file. I thought this would be a very hard task but looks very clean indeed.

You've also added some other nice tricks that will make the script hopefully faster.

One question: does /m:%NUMBER_OF_PROCESSORS% really enable building with multiple cores for you? I've tried using /MP and actually though that it's a default value, but I did not good for me. Jukka told me he gets automatic multicore builds from the build script (without /MP) but I never got it. Did you get them before you added these? How did you verify, it just feels faster?

The request looks good to me. I would still like to test the VC2008 build path before we merge this. Have you ran both with start to finish with this latest code? Does one need to build the old deps from scratch if this gets merged if I already have the current 2008 deps?

P.S. Protobuf can probably be solved the easiest if you just convert the 2008 solution into a 2010 by hand, commit that to the windows-utils like we have done for many other project/sln files.

Stinkfist0 commented 11 years ago

I'm pretty sure that /m:%NUMBER_OF_PROCESSORS% does what it supposed to do, on VS2010 at least. I have a desktop widget that shows the CPU usage for each cores and all were running ~100% + I could also see multiple cl.exes in the Windows Task Manager. I'll have to double check how it works also with VS2008.

I'm currently also testing the build script with VS2008 on the NoBoostVS2010 branch, so I'll make sure that VS2008 path will work also.

cadaver commented 11 years ago

This is looking good. A merge (with a minor fix related to the .NET framework 3.5 path) is imminent.

Stinkfist0 commented 11 years ago

Great! I'll see if I can find out a fix for Mumble/Celt/Speex in the near future.