Completion of error handling

[elfring]

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

• fseek ⇒ OpenAndDecodeUsingJ2K
• fwrite ⇒ EC_Terrain::SaveToFile

[Stinkfist0]

Sure, these are pretty trivial to fix.

[elfring]

I suggest to avoid ignorance of return values a bit more.

Are you interested to apply aspect-oriented software development? How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?

[antont]

Yes, IIRC @erno also noted earlier about some unhandled error places.

I found AOP quite interesting when it came, and i figure may make sense for something like that but have never actually so far used it yet so can't really say much about it.

Reusability is certainly interesting regarding error / problem handling situations - I had to fix some net error handling things in our game (not related to tundra) recently and was actually wondering what would be nice clean robust ways to do that.

[elfring]

How do you think about to improve static source code analysis also for your software?

Do you find information sources like the following useful?

• Article "A Reusable Aspect for Memory Allocation Checking"
• Document "Aspect-Oriented Software Development - An Introduction" by Johan Brichau and Theo D'Hondt
• Paper "On Typesafe Aspect Implementations in C++" by Daniel Lohmann and Olaf Spinczyk

[antont]

IIRC the guys have used static analysis in some projects .. I think it has been useful with Blender as well.

[Stinkfist0]

Closing as the reporter is some sort of bot it seems (see his activity: same issues with the same exact wording and replies on many other projects too).

[antont]

yah i noticed there were same notes for urho3d as well. if not bot perhaps copy-paste.