Request for feedback: PR for pagination

realadeel / pinterest-api

Ruby gem to interact with the official Pinterest REST API

MIT License

58 stars 37 forks source link

Request for feedback: PR for pagination #15

Closed westonplatter closed 6 years ago

westonplatter commented 6 years ago

I needed pagination for my purposes and wanted to give back.

Before I write the final tests for it and get it cleaned up, I wanted to get feedback on the changes.

realadeel commented 6 years ago

Thank you!!!

westonplatter commented 6 years ago

@realadeel can you unmerge this?

After I wrote the code, I found that the pagination did not work. API responses included unexpected HTTP params in the next page URI. I'll try to share what I came up with this weekend. In the mean time, I don't want to introduce bugs in the gem.