search

realaravinth / libmedium

An Alternative Medium Frontend | Development continues at: https://git.batsense.net/realaravinth/libmedium
https://libmedium.batsense.net
GNU Affero General Public License v3.0
74 stars 7 forks source link

[Bug] Line permalinking not working with multiple code blocks in article #32

Closed KaKi87 closed 4 months ago

KaKi87 commented 5 months ago

Hi,

Permalinking to a line of the 2nd+ code snippet of a page links to a line of the 1st code snippet of the page.

Thanks

realaravinth commented 4 months ago

Hello o/

Thanks for filing this issue! This PR uses unique IDs for permanent links, which should fix this issue. I'll ping once it's merged and published on GitHub too.

KaKi87 commented 4 months ago

Very well, thanks !

Would you rather that I had submitted the issue on your Forgejo instance ?

If so, I'd like to suggest changing the homepage Source Code link (next to the Demo Article one).

realaravinth commented 4 months ago

The long term goal is to switch to my Forgejo instance, but I don't mind receiving issues on GH also.

If so, I'd like to suggest changing the homepage Source Code link (next to the Demo Article one).

That's actually a very good idea, thanks!