search

realartists / shiphub-cocoa

MIT License
30 stars 5 forks source link

Can't react to comments on public issues #645

Open kogir opened 7 years ago

kogir commented 7 years ago

I tried to "thumbs up" a comment on an Orleans issue, but was not able to:

Pasted Image 1.png

This could of course be the GitHub API. I'll check on my side too.

james-howard commented 7 years ago

This isn't a string that appears in the client anywhere.

james-howard commented 7 years ago

I think we should file a bug with GitHub about this.

kogir commented 7 years ago

Ok, I'll send them an email in a bit.

james-howard commented 7 years ago

Turns out that this is intended behavior by GitHub. We need to detect these scenarios on the client and prompt to use a PAT / retry with the PAT. We also need to update the server to accept PATs when proxying api.github.com.