search

realbig / RBM_TH_EPIC

0 stars 0 forks source link

Featured Image (Logo) Showing at the top of Event Single #140

Closed d4mation closed 6 years ago

d4mation commented 6 years ago

From Document:

We can’t have the featured image go to the logo on the tile as well as top of the event page. Logos don’t work at the top of the event pages, we need images.

d4mation commented 6 years ago

@evasolo @marieepicraces I have a possible fix for this pushed up to Staging: http://epicraces.staging.wpengine.com/

It now shows what is in the Hero Image field. I also noticed some oddities with the Page Section layout regarding this, so I addressed those too.

BigActual commented 6 years ago

I think this is correct. @marieepicraces & @evasolo - Do you agree?

evasolo commented 6 years ago

We set a featured image for the private version of Hot Cocoa and we aren't able to see it when we view the page. Please keep Mary in the loop on this as she has been working on the pages quite a bit.

Be fit, be well, and keep smiling,

Eva Solomon Founder and CEO Epic Races, LLC

p: 734.585.7101 ext. 700 m: 734.678.5045 a: 600 South Wagner, Ann Arbor, MI 48103 w: epicraces.com https://www.epicraces.com/ e: eva@epicraces.com

On Mon, Sep 17, 2018 at 12:41 PM, BigActual notifications@github.com wrote:

I think this is correct. @marieepicraces https://github.com/marieepicraces & @evasolo https://github.com/evasolo - Do you agree?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/realbig/RBM_TH_EPIC/issues/140#issuecomment-422086251, or mute the thread https://github.com/notifications/unsubscribe-auth/APinatAIlE9d3LreBuC7fzFFYDZjMUy8ks5ub9CfgaJpZM4WlkMV .

d4mation commented 6 years ago

@maryepicraces Did you check for this fix on Staging? http://epicraces.staging.wpengine.com/

This fix is not on Live yet.

evasolo commented 6 years ago

I didn't realize it wasn't live. yes, it works in staging, but where does the hero image go?

Be fit, be well, and keep smiling,

Eva Solomon Founder and CEO Epic Races, LLC

p: 734.585.7101 ext. 700 m: 734.678.5045 a: 600 South Wagner, Ann Arbor, MI 48103 w: epicraces.com https://www.epicraces.com/ e: eva@epicraces.com

On Mon, Sep 17, 2018 at 2:04 PM, Eric Defore notifications@github.com wrote:

@maryepicraces https://github.com/maryepicraces Did you check for this fix on Staging? http://epicraces.staging.wpengine.com/

This fix is not on Live yet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/realbig/RBM_TH_EPIC/issues/140#issuecomment-422113908, or mute the thread https://github.com/notifications/unsubscribe-auth/APinatpkqSXNXNFrj4bg8soMbLrLKQi-ks5ub-RCgaJpZM4WlkMV .

BigActual commented 6 years ago

Change the fields so that the hero is for the hero image. The logo has it's own logo field and the Feature is used on the home page featured event tile.

d4mation commented 6 years ago

The Hero Image has its own upload field:

image

The Logo is read from the Featured Image.

There is no dedicated Logo field that I am aware of.

BigActual commented 6 years ago

@d4mation - Clarification, We currently see two fields on the Event dashboard view but there should be three fields; a) Hero Image, b) Logo, and c)Feature Tile. Please label these with the ideal size so our client understands where best to crop the images.

Our programming will place the:

d4mation commented 6 years ago

This has been pushed to Staging. I added a new field specific to the Tiles and added recommended sizes to each.

If no Tile image is added, it will use the Hero Image as the Tile instead.

BigActual commented 6 years ago

@evasolo - These changes need to be pushed to live to satisfy Marie's request. Do you approve the changes?

evasolo commented 6 years ago

Yes

Be fit, be well, and keep smiling,

Eva Solomon Founder and CEO Epic Races, LLC

p: 734.585.7101 ext. 700 m: 734.678.5045 a: 600 South Wagner, Ann Arbor, MI 48103 w: epicraces.com https://www.epicraces.com/ e: eva@epicraces.com

On Thu, Sep 20, 2018 at 1:46 PM, BigActual notifications@github.com wrote:

@evasolo https://github.com/evasolo - These changes need to be pushed to live to satisfy Marie's request. Do you approve the changes?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/realbig/RBM_TH_EPIC/issues/140#issuecomment-423273115, or mute the thread https://github.com/notifications/unsubscribe-auth/APinar_OlNZozbuBr4LXO4yDnp11gjJEks5uc9R6gaJpZM4WlkMV .

d4mation commented 6 years ago

This is now Live