Sometimes Used/New/All does not work correctly

d4mation commented 5 years ago

Bug Report

What's the issue you encountered?

Have you hard-refreshed your Browser? (Control+F5 on a PC, CMD+Shift+R on a Mac)

Yes

How can the issue be reproduced?

Click around the page. Try using pagination and swapping between Used/New. Eventually I was able to reproduce and it no longer updated the URL bar properly.

Link to the page in question:

http://pmwoodwind.wpengine.com/products/instruments/

What does your environment look like?

What Operating System are you running? (Windows 10, Mac OS X, Android, iOS, etc.) Mac OS X
What Web Browser are you using? Chrome 71.0.3578.98 64 bit
What is your screen resolution? (If you're on a mobile device, you can just list your device here) 2880 x 1800 Retina (So, 1440 x 877 in reality)

BigActual commented 5 years ago

How was this resolved?

d4mation commented 5 years ago

The hidden select field would remove options for "New" or "Used" if there were no matching results for the currently chosen Filters. This made it so that the "New" and "Used" links at the top of the page would try to change the hidden select field to a value that did not exist. So, I added some JavaScript to force-add the options to the hidden select field if they did not exist, thereby fixing the functionality.

FacetWP does not have a way to turn that functionality for Select fields, so this workaround was necessary.

Descriptive Commit Message and code can be found here: https://github.com/realbig/theme_pmwoodwinds/commit/6066383d1c3998dfce96e5c7ec32899be2f3193c

realbig / theme_pmwoodwinds