search

realbig / theme_pmwoodwinds

1 stars 0 forks source link

Last item added to product compare is removed from list of comparable items when the back space key is struck. #47

Closed BigActual closed 5 years ago

BigActual commented 5 years ago

https://d.pr/v/Yrzxtm

d4mation commented 5 years ago

I watched this video a few times and I never saw the item get removed 🤔 It was always in the Compare box.

BigActual commented 5 years ago

The video was cut off at the end. I did not watch it. I just made it and posted the link. I'll remake it.

BigActual commented 5 years ago

Link updated https://d.pr/v/Yrzxtm

d4mation commented 5 years ago

This seems to be caused by the browser holding a cache of the page from when it originally loaded and not loading the new values from the cookie that got set when the item got added to the compare.

If you refresh the page after you hit back in the browser, the removed instrument returns.

I'm not sure if there's much we could do about this. It would be worth attempting to report to the plugin developer for sure, but on our end I don't think anything else can be done.

BigActual commented 5 years ago

Can you force a page refresh?

d4mation commented 5 years ago

I might be able to devise something gross to detect this and force a page refresh. But it wouldn't occur until after JavaScript has loaded, so the page would basically load twice.

BigActual commented 5 years ago

Fine

d4mation commented 5 years ago

Pushed a fix for this. On Back or Forward via Browser Navigation (Backspace key, gestures, etc.) it will force a page refresh on Product Single.