realchonk / fuse-ufs

FUSE driver for FreeBSD's UFSv2
BSD 2-Clause "Simplified" License
7 stars 3 forks source link

lookup(): don't treat ENOENT as an error condition #40

Closed realchonk closed 3 months ago

realchonk commented 3 months ago

Fixes #39

realchonk commented 3 months ago

@asomers That's enough for me for today. It's 2am and I'm going to sleep. Have a nice rest of your day!

realchonk commented 3 months ago

Frankly, I'm not sure it's wise to use log::error! at all in the run method. There are lots of errors that are caused by the client. If you do want to log them, I suggest logging them at the debug level. That matches what fuser does. Oddly, while fuser logs the request, it never logs the response.

I'd really like to keep it as is, for now, because it helps with debugging. Buf I agree, once the driver is near completion, I'll inline run() everywhere and do more selective error reporting.