realcrowd / angularjs-utilities

Hopefully useful directives, providers, filters, etc for AngularJS
Other
199 stars 50 forks source link

rcMailgunValid directive #8

Open elielhaouzi opened 10 years ago

elielhaouzi commented 10 years ago

There is two problems in the rcMailgunValid directive.

  1. The mailgunStatus has no effect. it doesn't affect the scope.
  2. In the inProgressWrapper function, the variable error_message is not declared. (it seams that is a copy/paste of the errorWrapper function that there it is the function parameter)
mikey0000 commented 10 years ago

bump

anorborg commented 10 years ago

Apologies, I haven't responded sooner. I'll take a look at this is weekend and try to have something for you by Monday.

giuseppeminnella commented 8 years ago

Hi, I'm using this mailgun validator and it's great, thank you! However, I'm experiencing the same error regarding the error_message variable that is not declared. In my case it comes from here: if (baseInProgressCallback) baseInProgressCallback(error_message); line 91 in rcMailgun.js Are there any news on this issue?

P.s: I'm using angular 1.5 into a mean.js stack