Fix dynamic change of client_options.site

realdoug / omniauth-salesforce

OmniAuth strategy for salesforce.com

MIT License

65 stars 90 forks source link

Fix dynamic change of client_options.site #28

Open kriom opened 5 years ago

kriom commented 5 years ago

The client_options.site updated for the request_phase using request params is also updated for the callback_phase

Perhaps I'm wrong, but as it is possible to dynamically update the target client_options.site (eg : https://login.salesforce.com or https://test.salesforce.com) during the request_phase it seems logical to use this same site during the callback_phase, isn't ?

Best regards,

realdoug commented 5 years ago

@kriom can you add a test for this?