search

realestate-com-au / akamai-rspec

Test your akamai configuration with rspec
24 stars 13 forks source link

Implement our own get request class #10

Closed patrobinson closed 8 years ago

patrobinson commented 8 years ago

This is a rather large refactor of the Request class. We remove the monkey patch of RestClient::Request and implement our own get mechanism, using Net::HTTP. We re-use some of the RestClient::Request public methods to DRY it up, but I'm still undecided if it would be better to copy and paste the code from that library, to prevent future API changes from breaking this library.

There's a lot of refactoring that could have been done, and in fact was at first, but I've avoided doing so as this PR is already quite large.

The build is passing as can be seen in travis (setup on the forked repo) https://travis-ci.org/envato/akamai-rspec/builds/103266128

beegibson commented 8 years ago

Sorry I missed the email for this, that's for too long for you to wait :( - I'll read over it at lunch time today.

beegibson commented 8 years ago

Thanks, it looks so much better :+1:

beegibson commented 8 years ago

Unless you have objections I'd like to bring in the travis configuration you did, and run the build in REA's public travis?

beegibson commented 8 years ago

I just pushed the updates to rubygems as 0.2.5.

patrobinson commented 8 years ago

Nope go for it, would be great to have Travis in this repo. I can push a PR to this repo if you like?

beegibson commented 8 years ago

That'd be convenient, thanks.