search

realestate-com-au / akamai-rspec

Test your akamai configuration with rspec
24 stars 13 forks source link

Keep either url or response #15

Closed beegibson closed 8 years ago

beegibson commented 8 years ago

I disagree with removing the response option, I'm not sure why I accepted it. I think that it's nice to be able to use either a url or response, it's helpful when the user wants to check something about the response that akamai-rspec doesn't support. I also don't want to have to change the existing tests without a good reason.

I think I may have just accepted it because I was so happy that a stranger sent me a PR, and that clouded my judgement.

beegibson commented 8 years ago

This was discussed among the custodians outside of github, and we decided to merge it.