search

realestate-com-au / akamai-rspec

Test your akamai configuration with rspec
24 stars 13 forks source link

should http things be_verifiably_secure? #18

Closed jonhiggs closed 7 years ago

jonhiggs commented 8 years ago

should expect("http://something.com").to be_verifiably_secure evaluate to true?

mmollaverdi commented 8 years ago

I wouldn't say so. Does it?

jonhiggs commented 8 years ago

Yep.

beegibson commented 8 years ago

That sounds like a bug!

grantsheppard commented 8 years ago

@jonhiggs Do you mind sharing the URL that you were testing against?

grantsheppard commented 8 years ago

Just tried this against www.theage.com.au and confirmed that it is definitely not working as prescribed. My initial thoughts were that it was following a redirect but this certainly isn't the case.

grantsheppard commented 8 years ago

Guessing the problem stems from this change.

This reflects a gap in the tests as well.

jonhiggs commented 8 years ago

Thanks Grant. Let me know if you need anything else.

beegibson commented 8 years ago

Cool, can we assign someone to fix it or put a card on your wall @mmollaverdi and @grantsheppard?

grantsheppard commented 8 years ago

We'll undertake this as part of our custodianship work @biancaG, will discuss with team tomorrow.