realestate-com-au / akamai-rspec

Test your akamai configuration with rspec
24 stars 13 forks source link

Queries are going to the real url, not the Akamai URL. #9

Closed patrobinson closed 8 years ago

patrobinson commented 8 years ago

This PR so far only adds some failing tests to show that this is broken.

The Monkey Patch of RestClient is rather fragile. I think the solution to this is to remove RestClient all together; as it's only being used to wrap around Net::HTTP and URI modules it would be much easier to re-write the Request method to just use Net::HTTP directly. Let me know your thoughts.

beegibson commented 8 years ago

That breakage is concerning. It probably would be nicer to use Net:HTTP directly.

patrobinson commented 8 years ago

I have done some significant work, but I need to split the PR in two as I've done a lot of work on the specs as well. Will open a new one.