realestate-com-au / shush

It's a secret.
169 stars 36 forks source link

KMS ARN key syntax broken in version 1.4.0 #21

Closed boris-penev-zetta closed 2 years ago

boris-penev-zetta commented 4 years ago

Version 1.4.0 added the feature 'Allows aliases to be specified without alias/, saving those precious key-strokes'. The documentation says 'KEY-ID-OR-ALIAS can be the id or ARN of a KMS master key'. However, now the syntax that I am using in version 1.3.4, arn:aws:kms:<region>:<accid>:key/<key-id> no longer works, saying it is an invalid alias. <key-id> by itself works fine but I prefer to just copy the whole ARN from the KMS console. This means that key now can be id or alias but not ARN so this must be a regression.

I think the problem is that the newly added line main.go/50 assumes the key is either a UUID or alias but forgets about ARN.