search

realeyes-media / scte35-swift

Swift library for parsing SCTE35 data either via base64 or hex string
https://realeyes.com
MIT License
3 stars 2 forks source link

Request to add a Contributor License Agreement to repo #5

Open jonnybach opened 2 years ago

jonnybach commented 2 years ago

In order to be able to contribute to this repo as part of a Comcast employee, there needs to be in place a Contributor License Agreement applied to this repo.

Is this something that the maintainers are willing to add? Thank you!!!

coderjun commented 2 years ago

@jonnybach - Happy to help but I'd need some time to navigate Dolby OSS policies to answer your question. Here's a thought though

As a Comcast employee do you have a recommended Contributor License Agreement you might attach or even PR in? I wonder if a PR of a Contributor License would suffice as a repo with one? :)

jonnybach commented 2 years ago

@coderjun thanks for the reply! Let me get with the OSS team and see what they recommend. And yeah I'd be happy to put up a PR to add any licensing documentation to the repo.

coderjun commented 2 years ago

Sounds like a plan!

jonnybach commented 2 years ago

@coderjun I heard back from our Open source team at Comcast and they provided me insight into how Comcast and some other companies/individuals have done this:

Here is an example of the Comcast one: https://github.com/Comcast/comcast.github.io/blob/main/CONTRIBUTING.md

Here's google: https://cla.developers.google.com/about/google-individual

The trino folks just put it on a pdf and ask for a signed scanned copy sent back to their email, but this means someone has to maintain it: https://github.com/trinodb/cla

Instead of doing that, here's an easy CLA assistant that many companies including us use for the GitHub page: https://github.com/cla-assistant/cla-assistant

So there are two things: they have to make the CLA language and choose how they will collect signatures and maintain it

The contributor license seems to be a bit more involved in that signed agreements (electronic or otherwise) from contributors would need to be maintained. You might want to run this by management or legal team at Real Eyes to see if this is acceptable/doable?

coderjun commented 2 years ago

Hi @jonnybach thanks for this detailed investigation on your end, I really appreciate it. I have some folk on our end that I can chat through this with. I will be reaching out again soon and thanks for your patience!

jonnybach commented 2 years ago

Sounds great, thanks to you for looking into it.

coderjun commented 2 years ago

Hi @jonnybach just wanted to check in before too much time passed. I've had some internal chats on how to go about the above. They're just concluding and as a result I believe I have a path forward. If you can bear with me for the next week-ish I will follow back up hopefully with a solution to the CLA and License need on our end.

Thanks for the interest!

jonnybach commented 2 years ago

Hi @coderjun, this is no problem. I am happy to wait it out. In the mean time I'm going to start making the code changes necessary and should have a PR ready to submit in about 2 weeks. Worst case is I scrap the work, but I'm hopeful that we'll be able to move forward!

coderjun commented 2 years ago

Hi @jonnybach sorry for the extreme delay. I wanted to let you know I finally had a chance to work through this. I believe all you will need to do to is open a PR and you should see the CLA Assistant kick in. Hope to see your contribution and thank you for your help thus far!

jonnybach commented 2 years ago

Hi @coderjun, this is great! I'll try to have a PR for the changes posted in a couple of days.

coderjun commented 2 years ago

Sounds good. Get to it when you can and I will be here. I know I made you wait long enough. :)