Hotkeys can't be set for certain menu items

[realh]

KNOWN EFFECTED: Move Tab Left, Move Tab Right, Name Tab

I was trying to set hotkeys for Move Tab Left and Move Tab Right to emulate gnome-terminal's bindings, however it wouldn't let me set them in the interface.

I subsequently created a shortcuts file from the default, and added lines to match their menutext to try to manually set them, that did not work either.

Then, I tried changing them in the menu itself by hovering my mouse, and this worked for everything except for those listed above, the ones I actually need to set.

I came upon this bug report: http://sourceforge.net/tracker/?func=detail&aid=3209018&group_id=124080&atid=698428

This is apparently not fixed. I had this problem in gentoo with version stable 1.6.3 I then unmasked ~amd64 and tried version unstable 1.18.5, still broken.

I then looked at the git logs to see you made a change so that editable menu items are not determined by gconf anymore, and thinking perhaps something about this fixed the issue, I used git to retrieve the project via: git clone git://roxterm.git.sourceforge.net/gitroot/roxterm/roxterm

I then compiled the program myself, fresh, installed it... and now I have the new checkbox in the configuration to set editable or not.. but I STILL cannot set a hotkey for the menu items listed at the beginning of this report... but I can, of course, for all the other menu items I try.

I put forth effort to make sure I wasn't reporting a bug that was already fixed, so I'm pretty sure this one, and bug id 3209018 linked above, are both still very much open issues.

Reported by: nacitar

Original Ticket: roxterm/bugs/52

[realh]

What do git describe and the Help->About dialog show? Bug 3209018 affected the other tab menu items too and I fixed it shortly before the 1.21.4 release:

commit 1d5228b00e6d721bf5f18214826aa4c57d225c8d Author: Tony Houghton h@realh.co.uk Date: Mon Mar 14 17:09:46 2011 +0000

Allow all fixed Tabs shortcuts to be changed:

Fixes <http://sourceforge.net/tracker/?func=detail&aid=3209018&group_id=124080&atid=698428>.

It's still working for me now.

Original comment by: realh

[realh]

Just for verbosity, and to help you out with your project a bit.

GENTOO BUILD PROCESS

NOTE: a few things need fixed I think, like your symlink generation for automake, as well as some missing/renamed images.

1) http://sourceforge.net/tracker/?func=detail&aid=3209018&group_id=124080&atid=698428 2) sudo emerge transifex-client po4a 3) set up a user on http://www.transifex.net/ and run 'tx init' in my home folder to enter my info and generate the config file. 4) edit po/LINGUAS to say 'en' 5) cp po/roxterm.pot po/en.po 6) vim po4a/Makefile

uncomment all build targets with '.en' in the name

uncomment target roxterm.1.pot and roxterm-config.1.pot

7) ./bootstrap.sh 8) rm config.guess config.sub # these are broken symlinks 9) ln -s /usr/share/automake-1.11/config.guess config.guess 10) ln -s /usr/share/automake-1.11/config.sub config.sub 11) make 12) sudo make install

And all goes well up until: /home/username/tmp/roxterm/install-sh: ./Help/lib/roxterm_logo.png does not exist. make[2]: [install-data-local] Error 1 make[2]: Leaving directory `/home/username/tmp/roxterm' make[1]: [install-am] Error 2 make[1]: Leaving directory `/home/username/tmp/roxterm' make: *** [install-recursive] Error 1

13) # So, I copy logo_text_only.png over to that name just to get it to work cp Help/lib/logo_text_only.png Help/lib/roxterm_logo.png

try again, get: /home/username/tmp/roxterm/install-sh: ./Help/lib/logo_text.png does not exist.

cp Help/lib/logo_text_only.png Help/lib/logo_text.png
# next error: /home/username/tmp/roxterm/install-sh: ./Help/lib/favicon.ico does not exist.
touch ./Help/lib/favicon.ico

14) sudo make install

And now, it installs successfully.

ACTIONS

$ git describe 1.21.2-4-g4b4776b

$ roxterm Help -> About says ROXTerm 1.21.2.4~g4b4776b (c) 2005-2010 Tony Houghton http://roxterm.sourceforge.net

That matches my git describe.

I open roxterm, Preferences -> Configuration Manager, check "Enable editing", Close Open tabs menu, hover mouse over "Previous Tab", which shows the default shortcut of Ctrl+PageUp I verify I can change this by pressing ctrl-alt-O, it works fine and changes, so I change it back. I now hover my mouse over 'Name Tab...', try the same thing, nothing changes; it remains with no hotkey. I then open several tabs to make sure the Move Tab Left/Right options are both enabled, and try on them too. Doesn't work.

Need any more info and I can provide it; do take note above if you skip to the end that the gentoo build process has a few things I believe are errors in your build scripts (missing/renamed files).

Original comment by: nacitar

[realh]

Well, step (1) was meant to be erased... that's what happens when you reuse scratch files.

Original comment by: nacitar

[realh]

Actually, step 1 should have been

1) git clone git://roxterm.git.sourceforge.net/gitroot/roxterm/roxterm

But my paste buffer was wrong. wishes he could edit instead

Original comment by: nacitar

[realh]

Hmm, your shortlog: http://roxterm.git.sourceforge.net/git/gitweb.cgi?p=roxterm/roxterm;a=shortlog

It shows the most recent change on Mar 8th... your change you show above to fix shows Mar 14th..

Also the message for the most recent commit is: Merge branch 'master' of ssh://roxterm.git.sourceforge.net/gitroot/roxterm/roxterm

And the git request goes to: git://roxterm.git.sourceforge.net/gitroot/roxterm/roxterm

git:// versus ssh://

Do you have two repositories, one internal (ssh://) one external (git://), and the issue here is that you HAVE FIXED IT, however I can only obtain older code from git:// ?

Original comment by: nacitar

[realh]

I must have forgotten to git push :-/. I've rectified that now. I recommend you use the release tarball though. It's up to date and doesn't need transifex. Not being able to use tx without an account is a problem, I think I'll have to check the po files into git again and put up with the trivial merge conflicts.

bootstrap.sh contains some stuff specific to Debian packages which I'll have to change, because the debian directory is now always there even if not building for Debian. That's what broke your config.* files.

The missing graphics files are supposed to be built by the top-level make. You need imagemagick. I'm puzzled by the errors though. If you do have imagemagick it should just work, if you don't I would have expected it to fail with an unknown command error and not proceed to try to install the missing files.

Original comment by: realh

[realh]

I can confirm that I did not have imagemagick installed, hence prior issue with the earlier revision involving the pngs. It may have errored earlier when it failed to make them, but it didn't bail, so I didn't see it... i just saw the missing image message. So, the error appears to have been non-fatal, and it probably should be fatal.

I went ahead and grabbed your tarball this time around, and it built without error on gentoo, perfectly fine with configure, make, make install

Also, I can confirm that the problem is resolved at this point. To be honest, I completely overlooked the mention of the tarball on your installation page. My eyes saw "Download" section and then a code block with a git command and I just automatically, and stupidly, assumed the text above was telling me to use the command below. Though your git needed a push anyway, had I grabbed the tarball instead, I would have confirmed the bug was already resolved and you wouldn't be reading this ticket right now!

So, you might consider restructuring that bit of the page a bit to make it more clear/stand out to the eyes that you highly suggest use of the tarball, in case people like myself immediately skip to the code block upon seeing it.

Feel free to close this bug, thanks for being prompt. Now I just have to file a bug with gentoo to get them to pull this fixed version into the repository... :)

Original comment by: nacitar

[realh]

The files generated by imagemagick are included tarballs, so for most people the lack of imagemagick shouldn't be a fatal error. The files would probably be in the wrong place if the build directory isn't in the same place as the configure file though.

Original comment by: realh

[realh]

Fixed in 1.21.4

Original comment by: realh