realies / soulseek-docker

🐳 Soulseek Docker Container
https://hub.docker.com/r/realies/soulseek/
MIT License
217 stars 35 forks source link

NoVNC resize settings in index.html #12

Closed BudSpencer20 closed 4 years ago

BudSpencer20 commented 4 years ago

Hey realies,

Firstly great work on this SUPER useful docker container - now I can uninstall Soulseek from my computer and just run it on my Synology NAS - thank you very much for this :)

Just wanted to report an issue, on your index.html the NoVNC resize is "hardcoded" to scale, this means if you change your resize settings on the NoVNC left hand menu it defaults back to "scale" everytime you refresh your page.

In my humble suggestion would be to leave out the resize parameter in the index.html so that you can change the setting to however you want and it will survive page refreshes - I have tested this by editing the index.html in my docker container to remove the resize option and it works.

For instance,

Change this:

<iframe src="vnc.html?autoconnect=true&resize=scale"></iframe>

to this:

<iframe src="vnc.html?autoconnect=true"></iframe>

Again, thank you very much realies :)

BudSpencer20 commented 4 years ago

Great work realies, thanks very much for that :)