realies / soulseek-docker

🐳 Soulseek Docker Container
https://hub.docker.com/r/realies/soulseek/
MIT License
209 stars 35 forks source link

VNCPWD environment variable not working; container fails to launch #50

Closed DiamondShark closed 1 year ago

DiamondShark commented 2 years ago

Hi! When I try to build from a docker-compose file, here's the error that I get:

soulseek | /init.sh: 14: vncpasswd: not found soulseek exited with code 127

Here's the sample of the docker compose file!

soulseek:
    image: realies/soulseek
    container_name: soulseek
    environment:
      - VNCPWD=thisismysecretpassword
      # media group
      - PGID=1014
      # soulseek user
      - PUID=157
    volumes:
      - localdrive/data:/data/.SoulseekQt
      - localdrive/downloads:/Soulseek Downloads
      - localdrive/shared:/data/Soulseek Shared Folder
      - localdrive/logs:/data/Soulseek Chat Logs
    restart: unless-stopped
Maypul commented 2 years ago

I can also confirm this, still happening on latest build.

aketawi commented 1 year ago

Can confirm. Assumed it was a misconfiguration of some sorts on my end, but seems others have encountered this issue as well

gordon00 commented 1 year ago

Previous ubuntu was packaging vncpasswd into tigervnc-common, wich is installed by Dockerfile. (cf : https://manpages.ubuntu.com/manpages/focal/man1/tigervncpasswd.1.html)

But, since ubuntu 22.04LTS, vncpasswd is shipped by tigervnc-tools, wich is not currently installed by Dockerfile. (cf : https://manpages.ubuntu.com/manpages/jammy/man1/tigervncpasswd.1.html)

I am going to create a pull request to fix this.

@realies : it's kind of dangerous to use "FROM ubuntu:latest" into your Dockerfile because your build is dependant on when you build it. I think it would be more safe to explicitly set the base image you use.

gordon00 commented 1 year ago

Fixed here : https://github.com/gordon00/soulseek-docker/commit/fd16ed2668caea714c0fa1771dcf9efc594aeceb PR comming...

image

realies commented 1 year ago

Thanks to @gordon00, this appears to be fixed now.